fix(aws-lambda): add null handling for multiValueHeaders #13533
Merged
+47
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/aws-lambda
cherry-pick kong-ee
catbro666
approved these changes
Sep 4, 2024
tzssangglass
approved these changes
Sep 4, 2024
|
Successfully created cherry-pick PR for |
andrewgkew
pushed a commit
to andrewgkew/kong
that referenced
this pull request
Sep 5, 2024
A small PR for adding a null handling code for the multiValueHeaders field. Also contains a small refactor to put isBase64Encode check into the validate function to keep consistency with other fields FTI-6168
3 tasks
|
Successfully created backport PR for |
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13533-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13533-to-master-to-upstream
git checkout -b cherry-pick-13533-to-master-to-upstream
ancref=$(git merge-base c1bd5c6adb9a0d422204cd2e3812bfb54cc4d0cb 8259e8d99e5c54e84f3078bec44e8c73d687cc4c)
git cherry-pick -x $ancref..8259e8d99e5c54e84f3078bec44e8c73d687cc4c |
github-actions
bot
added
the
incomplete-cherry-pick
kikito
removed
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small PR for adding a null handling code for the
multiValueHeadersfield. Also contains a small refactor to putisBase64Encodecheck into the validate function to keep consistency with other fieldsChecklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-6168